Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(logger): short stringer for loggers #732

Merged
merged 13 commits into from
Oct 8, 2023
Merged

feat(logger): short stringer for loggers #732

merged 13 commits into from
Oct 8, 2023

Conversation

kehiy
Copy link
Contributor

@kehiy kehiy commented Oct 6, 2023

Description

@kehiy kehiy added the Log label Oct 6, 2023
@kehiy kehiy requested a review from b00f October 6, 2023 09:50
@kehiy kehiy self-assigned this Oct 6, 2023
b00f
b00f requested changes Oct 6, 2023
View reviewed changes
consensus/consensus.go Outdated Show resolved Hide resolved
crypto/address_test.go Outdated Show resolved Hide resolved
crypto/hash/hash_test.go Outdated Show resolved Hide resolved
state/state.go Outdated Show resolved Hide resolved
sync/bundle/message/block_announce.go Outdated Show resolved Hide resolved
types/tx/payload/transfer.go Outdated Show resolved Hide resolved
types/tx/payload/unbond.go Outdated Show resolved Hide resolved
types/tx/payload/withdraw.go Outdated Show resolved Hide resolved
types/tx/tx.go Outdated Show resolved Hide resolved
types/vote/vote.go Outdated Show resolved Hide resolved
@kehiy kehiy requested a review from b00f October 6, 2023 11:41
b00f
b00f requested changes Oct 7, 2023
View reviewed changes
types/block/block.go Outdated Show resolved Hide resolved
types/block/block.go Outdated Show resolved Hide resolved
types/vote/vote.go Outdated Show resolved Hide resolved
types/vote/vote.go Outdated Show resolved Hide resolved
@kehiy kehiy requested a review from b00f October 7, 2023 14:41
@codecov
Copy link

codecov bot commented Oct 8, 2023

Codecov Report

Merging #732 (efc8ef6) into main (bcf737a) will decrease coverage by 0.11%.
The diff coverage is 75.51%.

@@            Coverage Diff             @@
##             main     #732      +/-   ##
==========================================
- Coverage   82.75%   82.65%   -0.11%     
==========================================
  Files         172      172              
  Lines        8031     8036       +5     
==========================================
- Hits         6646     6642       -4     
- Misses       1070     1076       +6     
- Partials      315      318       +3

@b00f b00f merged commit 6a9a37f into pactus-project:main Oct 8, 2023
12 checks passed
@kehiy kehiy deleted the hotfix/logger branch October 8, 2023 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@b00f b00f b00f approved these changes

Assignees

@kehiy kehiy

Labels
Log
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kehiy @b00f