Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add absentee votes to the certificate #746

Merged

Conversation

amirvalhalla
Copy link
Member

@amirvalhalla amirvalhalla commented Oct 12, 2023

Description

This PR adds absentees votes to the block certificate.

@amirvalhalla amirvalhalla self-assigned this Oct 12, 2023
@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

Merging #746 (8ddc30b) into main (30eb753) will decrease coverage by 0.04%.
The diff coverage is 77.41%.

@@            Coverage Diff             @@
##             main     #746      +/-   ##
==========================================
- Coverage   82.88%   82.84%   -0.04%     
==========================================
  Files         173      173              
  Lines        8032     8044      +12     
==========================================
+ Hits         6657     6664       +7     
- Misses       1057     1060       +3     
- Partials      318      320       +2     

state/state.go Outdated Show resolved Hide resolved
@themantre themantre changed the title feat: add absentees to vote in consensus feat: add absentees to vote to the certificate Oct 12, 2023
@amirvalhalla amirvalhalla merged commit a838ea1 into pactus-project:main Oct 12, 2023
14 checks passed
@b00f b00f changed the title feat: add absentees to vote to the certificate feat: add absentee votes to the certificate Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants