refactor(sync): refactoring sync process #807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
themantre
force-pushed
the
refactor-sync
branch
from
40c80d5
to
088d7d7
Compare
Codecov Report
@@ Coverage Diff @@
## main #807 +/- ##
==========================================
+ Coverage 82.91% 83.01% +0.09%
==========================================
Files 173 173
Lines 8254 8319 +65
==========================================
+ Hits 6844 6906 +62
- Misses 1090 1093 +3
Partials 320 320 |
b00f
approved these changes
Nov 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The syncing process should be faster by 30% after this PR.
This PR simply re-downloads the incomplete sessions, if any exist.
It is normal to lose connection with some peers during the download.
Instead of downloading from the beginning, we attempt to fill the gaps between the downloaded blocks.