Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(logger): adding rotate log file after days, compress and max backups for logger config #822

Merged
merged 2 commits into from
Nov 29, 2023

Conversation

kehiy
Copy link
Contributor

@kehiy kehiy commented Nov 21, 2023

Description

we have 3 new options for logger config now.
the reason for a lot of compressed backup files was enabling compress by default, not setting max-age and rotate interval for them.
but now, all of them in configurable.

Related issue(s)

@kehiy kehiy added the Log label Nov 21, 2023
@kehiy kehiy requested a review from b00f November 21, 2023 20:41
@kehiy kehiy self-assigned this Nov 21, 2023
Copy link

codecov bot commented Nov 21, 2023

Codecov Report

Merging #822 (68030a2) into main (b2f230a) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #822      +/-   ##
==========================================
- Coverage   82.71%   82.71%   -0.01%     
==========================================
  Files         172      172              
  Lines        8360     8364       +4     
==========================================
+ Hits         6915     6918       +3     
- Misses       1118     1119       +1     
  Partials      327      327              

@kehiy
Copy link
Contributor Author

kehiy commented Nov 28, 2023

@b00f tests passed.

@b00f b00f merged commit 19f0063 into pactus-project:main Nov 29, 2023
12 checks passed
@kehiy kehiy deleted the feature/rotateLogs branch November 29, 2023 07:28
@themantre themantre changed the title feat(logger): adding rotate log file after days, compress and maxgae for logger config feat(logger): adding rotate log file after days, compress and max backups for logger config Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add option to config for rotating logfiles
2 participants