Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: sort wallet addresses #836

Merged
merged 10 commits into from
Dec 6, 2023

Conversation

amirvalhalla
Copy link
Member

Description

implement sorting wallet addresses based on PIP-8 and PIP-13

@amirvalhalla amirvalhalla self-assigned this Dec 4, 2023
@amirvalhalla amirvalhalla changed the title Feat: sort addresses of wallet feat:sort wallet addresses Dec 4, 2023
Copy link

codecov bot commented Dec 5, 2023

Codecov Report

Merging #836 (5a305c8) into main (f07c77f) will decrease coverage by 0.20%.
Report is 1 commits behind head on main.
The diff coverage is 74.54%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #836      +/-   ##
==========================================
- Coverage   83.37%   83.17%   -0.20%     
==========================================
  Files         170      170              
  Lines        8492     8572      +80     
==========================================
+ Hits         7080     7130      +50     
- Misses       1083     1101      +18     
- Partials      329      341      +12     

@b00f b00f changed the title feat:sort wallet addresses feat: sort wallet addresses Dec 5, 2023
@amirvalhalla amirvalhalla merged commit 26fcbed into pactus-project:main Dec 6, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants