Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixing gRPC node info issue #906

Merged
merged 10 commits into from
Jan 6, 2024
Merged

fix: fixing gRPC node info issue #906

merged 10 commits into from
Jan 6, 2024

Conversation

kehiy
Copy link
Contributor

@kehiy kehiy commented Jan 4, 2024

No description provided.

@kehiy kehiy requested a review from b00f January 4, 2024 10:08
Copy link

codecov bot commented Jan 4, 2024

Codecov Report

Merging #906 (0df1365) into main (b222d00) will increase coverage by 0.03%.
The diff coverage is 100.00%.

❗ Current head 0df1365 differs from pull request most recent head c290272. Consider uploading reports for the commit c290272 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #906      +/-   ##
==========================================
+ Coverage   83.30%   83.33%   +0.03%     
==========================================
  Files         173      173              
  Lines        8815     8815              
==========================================
+ Hits         7343     7346       +3     
+ Misses       1117     1115       -2     
+ Partials      355      354       -1     

@kehiy kehiy changed the title Reac fix: fixing gRPC node info issue Jan 4, 2024
www/grpc/network.go Outdated Show resolved Hide resolved
@kehiy kehiy requested a review from b00f January 6, 2024 10:55
@b00f b00f merged commit b84c561 into pactus-project:main Jan 6, 2024
10 checks passed
@kehiy kehiy deleted the reac branch January 6, 2024 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants