Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(consensus): turning consensus to a zero-config module #942

Merged
merged 5 commits into from
Jan 17, 2024

Conversation

kehiy
Copy link
Contributor

@kehiy kehiy commented Jan 16, 2024

Description

This changes will add the pip19 score to consensus config, and changes the consensus module to a zero-config module.

@kehiy kehiy added Documentation Improvements or additions to documentation Consensus labels Jan 16, 2024
@kehiy kehiy requested a review from b00f January 16, 2024 17:42
Copy link

codecov bot commented Jan 16, 2024

Codecov Report

Merging #942 (bdbd273) into main (9235e8d) will decrease coverage by 0.08%.
The diff coverage is 66.66%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #942      +/-   ##
==========================================
- Coverage   83.52%   83.45%   -0.08%     
==========================================
  Files         171      171              
  Lines        8827     8840      +13     
==========================================
+ Hits         7373     7377       +4     
- Misses       1103     1109       +6     
- Partials      351      354       +3     

@kehiy kehiy added the Mainnet label Jan 16, 2024
consensus/config.go Outdated Show resolved Hide resolved
consensus/config_test.go Outdated Show resolved Hide resolved
@b00f b00f changed the title chore: adding pip19 score to consensus config, turning consensus to a zero-config module feat(consensus): turning consensus to a zero-config module Jan 17, 2024
@kehiy kehiy requested a review from b00f January 17, 2024 08:23
@b00f b00f merged commit 1aa034c into pactus-project:main Jan 17, 2024
11 of 12 checks passed
@kehiy kehiy deleted the feature/consensusConfig branch January 17, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Consensus Documentation Improvements or additions to documentation Mainnet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants