Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(daemon): removing password, entropy and validator number as prompt, and adding flags instead #943

Merged
merged 5 commits into from
Jan 18, 2024
Merged

chore(daemon): removing password, entropy and validator number as prompt, and adding flags instead #943

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7b8568f
chore(daemon): removing password, entropy and validator number as pro…
kehiy Jan 17, 2024
df35d14
Merge branch 'main' into feature/daemonUpdate
kehiy Jan 17, 2024
8133303
Update init.go
kehiy Jan 17, 2024
db3b475
chore: beahaving like old versions for val-num
kehiy Jan 17, 2024
3144fbc
chore: adding else if to check max and min of num-val flag if it's set
kehiy Jan 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 14 additions & 10 deletions cmd/daemon/init.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,13 @@ func buildInitCmd(parentCmd *cobra.Command) {

restoreOpt := initCmd.Flags().String("restore", "", "Restore the default_wallet using a mnemonic (seed phrase)")

passwordOpt := initCmd.Flags().StringP("password", "p", "", "wallet password")

entropyOpt := initCmd.Flags().IntP("entropy", "e", 128, "entropy for seed generation, 128 (12 pass phrase) is default")

valNumOpt := initCmd.Flags().IntP("val-num", "", 7, "number of validator(s) to be created,"+
"default 7, minimum 1, maximum 32")

initCmd.Run = func(_ *cobra.Command, _ []string) {
workingDir, _ := filepath.Abs(*workingDirOpt)
if !util.IsDirNotExistsOrEmpty(workingDir) {
Expand All @@ -37,7 +44,7 @@ func buildInitCmd(parentCmd *cobra.Command) {
}
var mnemonic string
if *restoreOpt == "" {
mnemonic, _ = wallet.GenerateMnemonic(128)
mnemonic, _ = wallet.GenerateMnemonic(*entropyOpt)
cmd.PrintLine()
cmd.PrintInfoMsgf("Your wallet seed is:")
cmd.PrintInfoMsgBoldf(" " + mnemonic)
Expand All @@ -53,15 +60,12 @@ func buildInitCmd(parentCmd *cobra.Command) {
err := wallet.CheckMnemonic(*restoreOpt)
cmd.FatalErrorCheck(err)
}
cmd.PrintLine()
cmd.PrintInfoMsgf("Enter a password for wallet")
password := cmd.PromptPassword("Password", true)

cmd.PrintLine()
cmd.PrintInfoMsgBoldf("How many validators do you want to create?")
cmd.PrintInfoMsgf("Each node can run up to 32 validators, and each validator can hold up to 1000 staked coins.")
cmd.PrintInfoMsgf("You can define validators based on the amount of coins you want to stake.")
numValidators := cmd.PromptInputWithRange("Number of Validators", 7, 1, 32)
kehiy marked this conversation as resolved.
Show resolved Hide resolved
if *valNumOpt < 1 || *valNumOpt > 32 {
kehiy marked this conversation as resolved.
Show resolved Hide resolved
cmd.PrintErrorMsgf("%v is not in valid range of validator number, it should be between 1 and 32", *valNumOpt)

return
}

chain := genesis.Mainnet
// The order of checking the network (chain type) matters here.
Expand All @@ -71,7 +75,7 @@ func buildInitCmd(parentCmd *cobra.Command) {
if *localnetOpt {
chain = genesis.Localnet
}
validatorAddrs, rewardAddrs, err := cmd.CreateNode(numValidators, chain, workingDir, mnemonic, password)
validatorAddrs, rewardAddrs, err := cmd.CreateNode(*valNumOpt, chain, workingDir, mnemonic, *passwordOpt)
cmd.FatalErrorCheck(err)

cmd.PrintLine()
Expand Down
Loading