fix(datastore): mount cert in runner + improve logs + set hostname #320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
corrieriluca
commented
Aug 23, 2024
corrieriluca
commented
- Mount the CA certificate for the datastore in the runner pod the same way it was already done for Hermitcrab
- Add the hostname of the datastore in the config instead of being hardcoded for the default client implementation
- Improve logging of the datastore server by displaying the service account authenticated for every request
LucasMrqes
reviewed
Aug 23, 2024
Alan-pad
approved these changes
Sep 2, 2024
LucasMrqes
added a commit
that referenced
this pull request
Sep 6, 2024
This environment variable was dropped in #320, preventing the run pods to reach the datastore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.