Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Syntax error in Internet Explorer 11 (IE 11) #66

Closed
ilpssun opened this issue Jul 25, 2019 · 3 comments
Closed

Syntax error in Internet Explorer 11 (IE 11) #66

ilpssun opened this issue Jul 25, 2019 · 3 comments
Assignees
@tofi86
Labels
bug
Milestone
Version 0.5.1

Comments

@ilpssun
Copy link

ilpssun commented Jul 25, 2019

When I use version 0.5.0 of the plugin in Redmine 4.0.4, the javascript is not working in IE 11. It says that there is a syntax error in line 90 auf lightbox.js:

grafik

The same script is working fine in Firefox and Chrome/Chromium.

I'm no javascript expert – especially not regarding the differences between IE and FF/Chrome – so no clue as to what’s wrong with the line.
tofi86 added a commit that referenced this issue Sep 26, 2019
@tofi86
javascript bugfix for IE11 // fixes #66
05a6448 
IE11 does not support arrow functions
https://stackoverflow.com/questions/38595690/
@tofi86 tofi86 closed this as completed in 6eaad19 Sep 26, 2019
@tofi86
Copy link
Collaborator

tofi86 commented Sep 26, 2019

Thanks for the report. It's fixed on branch redmine-3.4 for Redmine 3.4 and on master for Redmine 4.x

I have not yet released a new version, but will soon.

@tofi86 tofi86 added this to the Next release milestone Sep 26, 2019
@tofi86 tofi86 added the bug label Sep 26, 2019
@tofi86 tofi86 self-assigned this Sep 26, 2019
tofi86 added a commit that referenced this issue Sep 26, 2019
@tofi86
bugfix for javascript bugfix for IE11 // refs #66
3a6c28c 
adds missing return. d'oh!
tofi86 added a commit that referenced this issue Sep 26, 2019
@tofi86
bugfix for javascript bugfix for IE11 // refs #66
3c3672e 
adds missing return. d'oh!
@tofi86
Copy link
Collaborator

tofi86 commented Sep 26, 2019

Sorry, the bugfix contained a bug 🙈 Now it's working and can be tested from the before mentioned branches.

@tainewoo
Copy link

image preview is ok now, but pdf preview still fails

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tofi86 tofi86

Labels
bug
Projects
None yet
Milestone
Version 0.5.1
Development

No branches or pull requests
3 participants
@tofi86 @ilpssun @tainewoo