This repository has been archived by the owner on Dec 6, 2023. It is now read-only.
[#153676720] script provisioners #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cloudify
force-pushed
the
153676720-script-provisioners
branch
from
e54970c
to
c137f2d
Compare
gunzip
reviewed
Jan 12, 2018
| [ | ||
| "ARM_SUBSCRIPTION_ID", | ||
| "ARM_CLIENT_ID", | ||
| "ARM_CLIENT_SECRET", | ||
| "ARM_TENANT_ID" | ||
| ] | ||
| .filter(e => process.env[e] == undefined || process.env[e] == "") | ||
| ].filter(e => process.env[e] === undefined || process.env[e] === ""); |
There was a problem hiding this comment.
and process.env[e] === null
| return reject(`Missing required env vars: ${missingEnvs.join(", ")}`); | ||
| } | ||
|
|
||
| const clientId = process.env.ARM_CLIENT_ID; |
There was a problem hiding this comment.
I'd rather put these at module level not inside the function body (sincerly I prefer the old implementation that leave the check for environment variables outside the scope of login() function)
cloudify
added a commit
that referenced
this pull request
Feb 28, 2019
* [#153676720] refactors cosmosdb collection provisioner to extract env check * [#153676720] Adds website git provisioner
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.