Skip to content
This repository has been archived by the owner on Dec 6, 2023. It is now read-only.

[#153676720] functionapp tf resource #41

Merged
merged 1 commit into from
Jan 15, 2018

Conversation

cloudify
Copy link
Contributor

No description provided.

@cloudify cloudify requested a review from gunzip January 12, 2018 16:45
"QueueStorageConnection" = "${azurerm_storage_account.azurerm_storage_account.primary_connection_string}"
"APPINSIGHTS_INSTRUMENTATIONKEY" = "${azurerm_application_insights.azurerm_application_insights.instrumentation_key}"
"FUNCTION_APP_EDIT_MODE" = "readonly"
"AzureWebJobsSecretStorageType" = "disabled"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd copy the comments for each settings from the old js task, in this case it was

       // AzureWebJobsSecretStorageType may be `disabled` or `Blob`
        // When set to `Blob` the API manager task won't be able
        // to retrieve the master key

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

until they fix the problem with connection strings, we can put connection strings in app settings if you prefix them by "CUSTOMCONNSTR" ie. "CUSTOMCONNSTR_COSMOSDB_URI"=....

@cloudify
Copy link
Contributor Author

I've created this PR hashicorp/terraform-provider-azurerm#695

@cloudify cloudify force-pushed the 153676720-script-provisioners branch from dc573b4 to 24006aa Compare January 15, 2018 16:01
@cloudify cloudify changed the title [#153676720] WIP functionapp tf resource [#153676720] functionapp tf resource Jan 15, 2018
@cloudify cloudify merged commit 40a166f into master Jan 15, 2018
@cloudify cloudify deleted the 153676720-script-provisioners branch January 15, 2018 17:42
cloudify added a commit that referenced this pull request Feb 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants