-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(IT Wallet): [SIW-1748] Credentials details screen, accessibility problems #6324
base: master
Are you sure you want to change the base?
fix(IT Wallet): [SIW-1748] Credentials details screen, accessibility problems #6324
Conversation
…ble to screen reader
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6324 +/- ##
==========================================
- Coverage 48.42% 47.00% -1.42%
==========================================
Files 1488 1818 +330
Lines 31617 36942 +5325
Branches 7669 8913 +1244
==========================================
+ Hits 15311 17366 +2055
- Misses 16238 19510 +3272
+ Partials 68 66 -2
... and 1442 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
The issue persists on iOS; the screen reader still fails to recognize the back and help buttons. Edit: I did another test and now the SR remains stuck inside the header, allowing to read title and buttons, but not the rest of the screen. |
Thank you @mastro993 for trying on iOS |
Short description
This PR fixes an accessibility issue where the screen reader could not correctly recognize the buttons (Back and contextual Help) when the header was set to transparent.
Warning: This solution has only been tested on Android.
List of changes proposed in this pull request
headerMode: "float"
option toItwPresentationCredentialDetailScreen
How to test
To test the fix, you can try removing the added
headerMode: "float"
option and observe how the screen reader behaves with and without it.Without
headerMode: "float"
https://github.com/user-attachments/assets/d28d7784-2138-4d9f-9d26-e15f9dcd641d
With
headerMode: "float"
https://github.com/user-attachments/assets/d204be98-9788-4fd6-843f-5d4a6bdf9a18