Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(IT Wallet): [SIW-1748] Credentials details screen, accessibility problems #6324

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

RiccardoMolinari95
Copy link
Collaborator

Short description

This PR fixes an accessibility issue where the screen reader could not correctly recognize the buttons (Back and contextual Help) when the header was set to transparent.

Warning: This solution has only been tested on Android.

List of changes proposed in this pull request

  • Added the headerMode: "float" option to ItwPresentationCredentialDetailScreen

How to test

To test the fix, you can try removing the added headerMode: "float" option and observe how the screen reader behaves with and without it.

Without headerMode: "float"
https://github.com/user-attachments/assets/d28d7784-2138-4d9f-9d26-e15f9dcd641d

With headerMode: "float"
https://github.com/user-attachments/assets/d204be98-9788-4fd6-843f-5d4a6bdf9a18

@RiccardoMolinari95 RiccardoMolinari95 requested a review from a team as a code owner October 23, 2024 13:24
@pagopa-github-bot pagopa-github-bot changed the title [SIW-1748] credentials details screen, accessibility problems fix(IT Wallet): [SIW-1748] Credentials details screen, accessibility problems Oct 23, 2024
@pagopa-github-bot
Copy link
Collaborator

pagopa-github-bot commented Oct 23, 2024

Affected stories

  • 🐞 SIW-1748: Sez. identità verificata non accessibile
    subtask of

Generated by 🚫 dangerJS against 39d88ce

Copy link

codecov bot commented Oct 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.00%. Comparing base (4f204b4) to head (39d88ce).
Report is 711 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6324      +/-   ##
==========================================
- Coverage   48.42%   47.00%   -1.42%     
==========================================
  Files        1488     1818     +330     
  Lines       31617    36942    +5325     
  Branches     7669     8913    +1244     
==========================================
+ Hits        15311    17366    +2055     
- Misses      16238    19510    +3272     
+ Partials       68       66       -2     
Files with missing lines Coverage Δ
...features/itwallet/navigation/ItwStackNavigator.tsx 36.36% <ø> (ø)

... and 1442 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb1583e...39d88ce. Read the comment docs.

@mastro993
Copy link
Contributor

mastro993 commented Oct 30, 2024

The issue persists on iOS; the screen reader still fails to recognize the back and help buttons.

Edit: I did another test and now the SR remains stuck inside the header, allowing to read title and buttons, but not the rest of the screen.

@RiccardoMolinari95
Copy link
Collaborator Author

The issue persists on iOS; the screen reader still fails to recognize the back and help buttons.

Edit: I did another test and now the SR remains stuck inside the header, allowing to read title and buttons, but not the rest of the screen.

Thank you @mastro993 for trying on iOS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants