Skip to content

Commit

Permalink
fix: evals assume no context if response has no source_nodes
Browse files Browse the repository at this point in the history
  • Loading branch information
bboinay committed Aug 15, 2024
1 parent 7dd1bc5 commit f27d0ee
Showing 1 changed file with 8 additions and 5 deletions.
13 changes: 8 additions & 5 deletions evals/eval_utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -7,12 +7,15 @@ def values_only(table_data):

def extract_from_response(response):
# creates context using 'text' from each 'node' in response's 'source_nodes'. also deletes any instances of '\n'
if not response or not response.source_nodes:
raise ValueError("Response is empty or invalid")
if not response:
raise ValueError("Response is empty")

source_nodes = response.source_nodes
context_list = [source_node.node.text.replace('\n', '') for source_node in source_nodes]
context = '\n\n'.join(context_list)
if hasattr(response, 'source_nodes'):
source_nodes = response.source_nodes
context_list = [source_node.node.text.replace('\n', '') for source_node in source_nodes]
context = '\n\n'.join(context_list)
else:
context = ''

output = response.response

Expand Down

0 comments on commit f27d0ee

Please sign in to comment.