Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pipeline5 #31

Merged
merged 11 commits into from
Aug 6, 2024
Merged

Pipeline5 #31

merged 11 commits into from
Aug 6, 2024

Conversation

jjmchew
Copy link
Contributor

@jjmchew jjmchew commented Aug 6, 2024

Should merge all of my prior updates:

  • addition of .pylintrc file
  • inclusion of pytest and initial test file
  • refactoring to create "pipeline" module
  • use of FastAPI APIRouter for "chatbots" routes

@jjmchew jjmchew requested a review from bboinay August 6, 2024 18:45
tlane25
tlane25 approved these changes Aug 6, 2024
View reviewed changes
Copy link
Contributor

@tlane25 tlane25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I think we avoided major conflicts

@jjmchew jjmchew merged commit f492607 into main Aug 6, 2024
0 of 3 checks passed
@jjmchew jjmchew deleted the pipeline5 branch August 6, 2024 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tlane25 tlane25 tlane25 approved these changes

@bboinay bboinay Awaiting requested review from bboinay

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jjmchew @tlane25 @yg-lim