Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Graalvm 23 #413

Merged
merged 5 commits into from
Oct 4, 2024
Merged

Graalvm 23 #413

merged 5 commits into from
Oct 4, 2024

Conversation

pivotal-david-osullivan
Copy link
Contributor

Summary

Adds Java 23 Support

Use Cases

Checklist

  • I have viewed, signed, and submitted the Contributor License Agreement.
  • I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
  • I have added an integration test, if necessary.
  • I have reviewed the styleguide for guidance on my code quality.
  • I'm happy with the commit history on this PR (I have rebased/squashed as needed).

@pivotal-david-osullivan pivotal-david-osullivan added semver:minor A change requiring a minor version bump type:dependency-upgrade A dependency upgrade labels Sep 27, 2024
dmikusa
dmikusa approved these changes Oct 4, 2024
View reviewed changes
Copy link
Contributor

@dmikusa dmikusa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Are you expecting the test failures? I see the sha hashes are empty, is the expectation that the pipeline will fill these in after merging?

@pivotal-david-osullivan
Copy link
Contributor Author

Looks good to me. Are you expecting the test failures? I see the sha hashes are empty, is the expectation that the pipeline will fill these in after merging?

Yep exactly! 🤞

@dmikusa dmikusa merged commit 42ee1b1 into main Oct 4, 2024
4 of 5 checks passed
@dmikusa dmikusa deleted the graalvm-23 branch October 4, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmikusa dmikusa dmikusa approved these changes

Assignees
No one assigned
Labels
semver:minor A change requiring a minor version bump type:dependency-upgrade A dependency upgrade
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pivotal-david-osullivan @dmikusa