Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set application location even if server.xml defines app config #348

Merged
merged 6 commits into from
Mar 8, 2023
Merged

Set application location even if server.xml defines app config #348

merged 6 commits into from
Mar 8, 2023

Commits on Mar 8, 2023

  1. Fix app config detection 

    * Require an `id` to be set if any app config is provided in the
  server.xml which is necessary for proper app config merging.
* Buildpack now detects and merges application configurations spread
  across different app config elements.
* Buildpack now detects app configs using `webApplication` and
  `enterpriseApplication` in addition to `application`
    @hibell
    hibell authored and Hank W Ibell committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    f5e77f7 View commit details
    Browse the repository at this point in the history

  2. Apply suggestions from code review 

    Remove unnecessary newlines.

Co-authored-by: Daniel Mikusa <[email protected]>
    @hibell @dmikusa
    2 people authored and Hank W Ibell committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    9c28cd1 View commit details
    Browse the repository at this point in the history

  3. Remove unnecessary newlines

    @hibell
    hibell authored and Hank W Ibell committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    6656522 View commit details
    Browse the repository at this point in the history

  4. Set a default app ID 

    This allows Liberty to correctly merge app configs.
    @hibell
    hibell authored and Hank W Ibell committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    243ea25 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' into check-other-app-config

    @kevin-ortega
    kevin-ortega authored Mar 8, 2023
    Configuration menu
    Copy the full SHA
    2ff7e55 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'main' into check-other-app-config

    @kevin-ortega
    kevin-ortega authored Mar 8, 2023
    Configuration menu
    Copy the full SHA
    66f4add View commit details
    Browse the repository at this point in the history