Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add detection logging messages at info level #462

Merged
merged 1 commit into from
May 18, 2023

Conversation

anthonydahanne
Copy link
Member

Log messages were checked during testing

=== RUN   TestUnit/liberty/Detect/fails_if_a_Main-Class_is_present
SKIPPED: Detected build source is null

Summary

This PR adds additional logging when Detect returns false for this buildpack. This is to provide more information about why the detection failed for this buildpack when verbose/debug logging is enabled.

As of lifecycle v1.16.0, if the detect phase fails as a whole, log messages are printed at info level by default, without the need for the verbose flag.

Use Cases

A pack build command with the --verbose flag set will show these log statement if detection fails. If Detect succeeds, the output is not shown unless --verbose is set.

Checklist

  • I have viewed, signed, and submitted the Contributor License Agreement.
  • I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
  • I have added an integration test, if necessary.
  • I have reviewed the styleguide for guidance on my code quality.
  • I'm happy with the commit history on this PR (I have rebased/squashed as needed).

@anthonydahanne anthonydahanne requested review from a team as code owners May 18, 2023 15:19
@anthonydahanne anthonydahanne added type:enhancement A general enhancement semver:patch A change requiring a patch version bump labels May 18, 2023
@pivotal-david-osullivan pivotal-david-osullivan merged commit d3a938b into main May 18, 2023
@pivotal-david-osullivan pivotal-david-osullivan deleted the detect-logging branch May 18, 2023 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver:patch A change requiring a patch version bump type:enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants