Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Close #252 : Disable ToLower in some cases #253

Merged
merged 2 commits into from
Mar 10, 2023
Merged

Close #252 : Disable ToLower in some cases #253

merged 2 commits into from
Mar 10, 2023

Conversation

anthonydahanne
Copy link
Member

@anthonydahanne anthonydahanne commented Feb 25, 2023 •
edited
Loading

  • if an argument is named "--add-modules", next argument must not be lowered case

Checklist

  • I have viewed, signed, and submitted the Contributor License Agreement.
  • I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
  • I have added an integration test, if necessary.
  • I have reviewed the styleguide for guidance on my code quality.
  • I'm happy with the commit history on this PR (I have rebased/squashed as needed).

@anthonydahanne anthonydahanne requested a review from a team as a code owner February 25, 2023 01:25
dmikusa
dmikusa reviewed Feb 25, 2023
View reviewed changes
jlink.go Outdated Show resolved Hide resolved
@anthonydahanne anthonydahanne force-pushed the fix-252-jlink-caps branch 2 times, most recently from 6af86c2 to a78aebe Compare March 7, 2023 18:26
dmikusa
dmikusa requested changes Mar 10, 2023
View reviewed changes
Copy link
Contributor

@dmikusa dmikusa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Just two very minor changes.

jlink.go Outdated Show resolved Hide resolved
jlink_test.go Outdated Show resolved Hide resolved
@dmikusa dmikusa added type:bug A general bug semver:patch A change requiring a patch version bump labels Mar 10, 2023
anthonydahanne and others added 2 commits March 9, 2023 22:03
@anthonydahanne
Close paketo-buildpacks#252 : Disable ToLower in some cases
5207b28 
* use lowercase to perform the comparison, and keep the original passed
  as an argument
@anthonydahanne @dmikusa
Close paketo-buildpacks#252: use the short variable declaration
625cc92 
Co-authored-by: Daniel Mikusa <[email protected]>
@dmikusa dmikusa merged commit fc6777a into paketo-buildpacks:main Mar 10, 2023
@anthonydahanne anthonydahanne deleted the fix-252-jlink-caps branch March 10, 2023 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmikusa dmikusa dmikusa approved these changes

Assignees
No one assigned
Labels
semver:patch A change requiring a patch version bump type:bug A general bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anthonydahanne @dmikusa