feat: add support for mjs files when finding apps #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refs: paketo-buildpacks/node-start#225 Signed-off-by: Michael Dawson <[email protected]>
mhdawson
requested review from
brayanhenao and
paketo-bot-reviewer
and removed request for
a team
|
@pacostas if you can take a look when you get back. |
|
@mhdawson Looks good. Should we also add support for |
|
@pacostas adding .cjs probably makes sense as well. I'm away on holiday next week so maybe we can land this and I'll add another PR to add that once I'm back. |
pacostas
approved these changes
Aug 9, 2024
mhdawson
added a commit
to mhdawson/libnodejs
that referenced
this pull request
Aug 20, 2024
Refs: paketo-buildpacks/node-start#225 Refs: paketo-buildpacks#31 Signed-off-by: Michael Dawson <[email protected]>
5 tasks
pacostas
pushed a commit
that referenced
this pull request
Aug 22, 2024
Refs: paketo-buildpacks/node-start#225 Refs: #31 Signed-off-by: Michael Dawson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: paketo-buildpacks/node-start#225
Summary
Add support for .mjs files when looking for Node.js applications. Node.js added support for mjs a while ago.
Use Cases
An application where the main script file is an
.mjsfileChecklist