Support No package.json #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the NodeJSMainModule function would return an error if a NodeJS application did not have a package.json file. This was incorrect as it is possible to have a legal NodeJS application without one and the Paketo NodeJS buildpack supports this style of application. This change updates the detection logic to return server.js in cases where there is no package.json or the package.json does not explicitly identify a main, in line with the behavior of the Paketo NodeJS buildpack. Signed-off-by: Ben Hale <[email protected]>
nebhale
added
semver:minor
ekcasey
approved these changes
Oct 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the
NodeJSMainModulefunction would return an error if a NodeJS application did not have apackage.jsonfile. This was incorrect as it is possible to have a legal NodeJS application without one and the Paketo NodeJS buildpack supports this style of application.This change updates the detection logic to return
server.jsin cases where there is nopackage.jsonor thepackage.jsondoes not explicitly identify amain, in line with the behavior of the Paketo NodeJS buildpack.