Dependency mappings #4
Conversation
This allows users in an airgapped environment or an environment with restrictive firewall rules to map dependencies to new URIs that are accessible from the build environment Signed-off-by: Emily Casey <[email protected]>
Signed-off-by: Emily Casey <[email protected]>
ekcasey
force-pushed
the
dependency-mappings
branch
from
40f62ee
to
884bb81
Compare
dependency_mapping.go
Outdated
| ) | ||
|
|
||
| // MappingsFile defines dependency mappings for a set of buildpacks | ||
| type MappingsFile struct { |
There was a problem hiding this comment.
Why not hide this implementation details?
dependency_mapping.go
Outdated
| } | ||
|
|
||
| // ReadMappingsFile read MappingsFile from path | ||
| func ReadMappingsFile(path string) (MappingsFile, error) { |
There was a problem hiding this comment.
By returning ([]BuildpackMappings, error) instead?
There was a problem hiding this comment.
I had that originally but I thought somebody could realistically want to use this library to write the file in the correct format
There was a problem hiding this comment.
happy to change it back if you think that is unrealistic
There was a problem hiding this comment.
Yeah, I wouldn't optimize for that right now. It's a good thought, but I'm pretty realistic that we're the only ones that are going to use this.
dependency_cache.go
Outdated
| var mappings []DependencyMapping | ||
| for _, bpm := range mappingsFile.BuildpackMappings { | ||
| if bpm.BuildpackID == context.Buildpack.Info.ID { | ||
| mappings = bpm.Mappings |
There was a problem hiding this comment.
There should also be a log message (not sure of how prominent we want it to be) that mentions that mappings are going to be used for this buildpack.
There was a problem hiding this comment.
Omitting this for now because the Logger is not injected into the constructor
* Better error messages * Handling missing mappings file * Don't export entire file schema Signed-off-by: Emily Casey <[email protected]>
ekcasey
force-pushed
the
dependency-mappings
branch
from
9f75195
to
0f8eb47
Compare
nebhale
added
semver:minor
Resolves #3