Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removes jammy node v20 deps to force bionic compilation #695

Merged
merged 2 commits into from
Aug 31, 2023
Merged

Removes jammy node v20 deps to force bionic compilation #695

merged 2 commits into from
Aug 31, 2023

Conversation

thitch97
Copy link
Contributor

@thitch97 thitch97 commented Aug 23, 2023 •
edited
Loading

#683 added only the jammy v20 deps in the hope that the automation would eventually fill in the bionic dependencies. Removing those deps to force the retrieval and compilation of all v20 deps since the aforementioned approach did not work as intended.

Checklist

  • I have viewed, signed, and submitted the Contributor License Agreement.
  • I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
  • I have added an integration test, if necessary.
  • I have reviewed the styleguide for guidance on my code quality.
  • I'm happy with the commit history on this PR (I have rebased/squashed as needed).

@thitch97 thitch97 requested a review from a team as a code owner August 23, 2023 15:13
@thitch97 thitch97 added the semver:minor A change requiring a minor version bump label Aug 23, 2023
@TisVictress TisVictress merged commit 4c054b8 into main Aug 31, 2023
9 checks passed
@TisVictress TisVictress deleted the rm-node20 branch August 31, 2023 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robdimsdale robdimsdale robdimsdale approved these changes

@TisVictress TisVictress TisVictress approved these changes

@ryanmoran ryanmoran Awaiting requested review from ryanmoran ryanmoran is a code owner automatically assigned from paketo-buildpacks/nodejs-maintainers

Assignees
No one assigned
Labels
semver:minor A change requiring a minor version bump
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thitch97 @robdimsdale @TisVictress