Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updates actions with source output, fixes bug #1325

Merged
merged 3 commits into from
Oct 12, 2023
Merged

Conversation

pivotal-david-osullivan
Copy link
Contributor

@pivotal-david-osullivan pivotal-david-osullivan commented Oct 9, 2023

Summary

Adds source/source-sha outputs to the following actions:

  • Github Release - this required grabbing the original TagName from the Release object, since the action overwrites the TagName as it loops through releases.
  • Gradle
  • IBM Semeru
  • Leiningen
  • Liberty - this adds sources only if the dependency contains 'openliberty', since the 'websphere' deps are not OSS

Other action updates contain a bug fix when checking the list of sources for empty, it previously checked for nil which won't happen on an empty map, it now checks for length >0

The Skywalking action fixes a bug where an extra / was added to the dependency/binary URI

Use Cases

Checklist

  • I have viewed, signed, and submitted the Contributor License Agreement.
  • I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
  • I have added an integration test, if necessary.
  • I have reviewed the styleguide for guidance on my code quality.
  • I'm happy with the commit history on this PR (I have rebased/squashed as needed).

actions/github-release-dependency/main.go Show resolved Hide resolved
actions/gradle-dependency/main.go Outdated Show resolved Hide resolved
actions/leiningen-dependency/main.go Outdated Show resolved Hide resolved
actions/npm-dependency/main.go Outdated Show resolved Hide resolved
actions/npm-dependency/main.go Show resolved Hide resolved
actions/skywalking-dependency/test Outdated Show resolved Hide resolved
actions/gradle-dependency/main.go Outdated Show resolved Hide resolved
actions/leiningen-dependency/main.go Outdated Show resolved Hide resolved
actions/npm-dependency/main.go Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver:minor A change requiring a minor version bump type:enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants