-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for arm64 archives #1333
Conversation
This comment is for bellsoft
|
This comment is for
|
Is introducing new fields like |
* with a new input, ARM_GLOB
f3929a9
to
1819bed
Compare
Yes, that's the idea, that each "arm64 compatible BP" has a both
well, there's this one that's still open: paketo-buildpacks/rfcs#297 ; but we also discussed with you to rather have a map for Anyways, the idea here is to ease the early adopters experience (ie have a Paketo option rather than some personal repos); could we have those 2 fields as "alpha" fields that could be removed any day? Or we could just hack around WDYT? |
I think this RFC should be for what we do in the future with the metadata, outside of buildpack.toml. Possibly the url/sha256 as maps of data or some other format that might be more compact.
My worry about introducing these is that if we don't get team buy-in first, others may implement things differently and then we have a fragmented implementation. We could probably do it without any structure changes while taking on a little bit of duplication/bloat in buildpack.toml. I'm Ok with that in the short term, with the same goal as you, which is getting people able to use this more quickly. What if we go from this:
to this...
The differences:
I think that would actually work without any changes to libpak. It might even with within the context of pipeline builder updates/actions without any changes too. You'd just need to add another entry in pipeline-descriptor.yml for that I think that we'd need to change, and I can't recall if this ever got into pipeline-builder, is to give it the ability to filter out some dependencies when you package offline. Then you could pass it a regex when you package that forces it to only bundle some of the dependencies. With that flag, you could build one set for AMD64 and one for ARM64. Thoughts on that approach? |
closed in favor of #1348 |
Summary
Add support for arm64 archives
Use Cases
We need buildpacks to have arm64 metadata, to enable dual arch support
Checklist