Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore missing integration tests #1611

Merged
merged 2 commits into from
May 17, 2024
Merged

Restore missing integration tests #1611

merged 2 commits into from
May 17, 2024

Conversation

dmikusa
Copy link
Contributor

@dmikusa dmikusa commented May 15, 2024

Summary

Integration tests are missing in this repo. A recent set integration tests to only run when packaging, but other repos may have integration test, like this one. This change adjusts it so that integration tests are added for any repo that has them.

This also fixes TTL_SH_PUBLISH, which was causing some noise when not set.

Checklist

  • I have viewed, signed, and submitted the Contributor License Agreement.
  • I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
  • I have added an integration test, if necessary.
  • I have reviewed the styleguide for guidance on my code quality.
  • I'm happy with the commit history on this PR (I have rebased/squashed as needed).

This fixes an error where it tries to access this env and it's not set, which is an error cause our strict script settings

Signed-off-by: Daniel Mikusa <[email protected]>
@dmikusa dmikusa added type:bug A general bug semver:patch A change requiring a patch version bump labels May 15, 2024
@dmikusa dmikusa requested a review from a team as a code owner May 15, 2024 03:09
@dmikusa
Copy link
Contributor Author

dmikusa commented May 15, 2024

Idk why Github is not actually running the integration tests here. It just hangs forever waiting for them to run.

@anthonydahanne
Copy link
Member

is there a repo where those changes were run?

@dmikusa
Copy link
Contributor Author

dmikusa commented May 17, 2024

@anthonydahanne We don't have a good repo on which to test and push up changes. With canary, it's a no-op because that's an actual buildpack. That's the expected behavior.

I've run this on a few buildpacks locally and confirmed it has no changes (one component, one composite). I've also run it on the libs and of course on pipeline-builder itself which is where the problem manifests (see how "Integration Test" just sits at "Expected Waiting for status to be reported"). It works as expected in those cases.

@anthonydahanne anthonydahanne merged commit 654c474 into main May 17, 2024
9 checks passed
@anthonydahanne anthonydahanne deleted the ttlsh-fix branch May 17, 2024 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver:patch A change requiring a patch version bump type:bug A general bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants