-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restore missing integration tests #1611
Conversation
This fixes an error where it tries to access this env and it's not set, which is an error cause our strict script settings Signed-off-by: Daniel Mikusa <[email protected]>
Signed-off-by: Daniel Mikusa <[email protected]>
Idk why Github is not actually running the integration tests here. It just hangs forever waiting for them to run. |
is there a repo where those changes were run? |
@anthonydahanne We don't have a good repo on which to test and push up changes. With canary, it's a no-op because that's an actual buildpack. That's the expected behavior. I've run this on a few buildpacks locally and confirmed it has no changes (one component, one composite). I've also run it on the libs and of course on pipeline-builder itself which is where the problem manifests (see how "Integration Test" just sits at "Expected Waiting for status to be reported"). It works as expected in those cases. |
Summary
Integration tests are missing in this repo. A recent set integration tests to only run when packaging, but other repos may have integration test, like this one. This change adjusts it so that integration tests are added for any repo that has them.
This also fixes TTL_SH_PUBLISH, which was causing some noise when not set.
Checklist