Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support workflow job environments #397

Merged
merged 1 commit into from
Oct 7, 2021

Conversation

deimantastumas
Copy link
Contributor

@deimantastumas deimantastumas commented Oct 4, 2021

Summary

GitHub Actions environments are now generally available for GitHub Actions on GitHub Enterprise Server. Changes address it by adding the Environment field into the workflow job struct.

Use Cases

Adding the environment to the workflow job when building a pipeline.

Checklist

  • I have viewed, signed, and submitted the Contributor License Agreement.
  • I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
  • I have added an integration test, if necessary.
  • I have reviewed the styleguide for guidance on my code quality.
  • I'm happy with the commit history on this PR (I have rebased/squashed as needed).

@deimantastumas deimantastumas requested a review from a team October 4, 2021 09:13
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Oct 4, 2021

CLA Signed

The committers are authorized under a signed CLA.

@deimantastumas
Copy link
Contributor Author

Just wanted to point out that I've signed the CLA after submitting the PR.

@dmikusa
Copy link
Contributor

dmikusa commented Oct 4, 2021

Just wanted to point out that I've signed the CLA after submitting the PR.

Thanks for signing the CLA. The EasyCLA bot should pick up on that if things are complete, but there is still something it doesn't like. Can you try clicking the doc link in the note from EasyCLA and following the instructions there? It is particular about the way you submit stuff so that it can verify you've signed the CLA. We are not permitted to accept a PR unless EasyCLA gives the 👍 so we need to get that resolved.

Aside from that, the PR is small and looks reasonable. Can you expand on why it's needed though? I see you adding the field to the struct, but nothing is using it. What's missing by not having it in there? What doesn't work at present? I'm just trying to understand the purpose of adding it. Thanks

@deimantastumas
Copy link
Contributor Author

deimantastumas commented Oct 4, 2021

Thank you for such a quick response! Looks like I've managed to settle down CLA issues :D

Can you expand on why it's needed though?

I'm aware that pipeline-builder itself doesn't have any uses for environments as of this day, perhaps it will be useful in the future since GitHub supports it. As for my needs - I'm using pipeline-builder as a Go library in my separate application that converts DroneCI pipelines into GHA workflows. Most of the workflows require the usage of environments, hence it would be great if the builder supported this field 👍

Support workflow job environments
@dmikusa
Copy link
Contributor

dmikusa commented Oct 5, 2021

OK, thanks for the additional detail. That seems reasonable. I will need to review and see how this will impact our pipelines. I'll get back to you shortly.

@dmikusa dmikusa added semver:patch A change requiring a patch version bump type:enhancement A general enhancement labels Oct 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver:patch A change requiring a patch version bump type:enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants