-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support workflow job environments #397
Support workflow job environments #397
Conversation
|
Just wanted to point out that I've signed the CLA after submitting the PR. |
Thanks for signing the CLA. The EasyCLA bot should pick up on that if things are complete, but there is still something it doesn't like. Can you try clicking the doc link in the note from EasyCLA and following the instructions there? It is particular about the way you submit stuff so that it can verify you've signed the CLA. We are not permitted to accept a PR unless EasyCLA gives the 👍 so we need to get that resolved. Aside from that, the PR is small and looks reasonable. Can you expand on why it's needed though? I see you adding the field to the struct, but nothing is using it. What's missing by not having it in there? What doesn't work at present? I'm just trying to understand the purpose of adding it. Thanks |
c2d9a22
to
dbb8203
Compare
Thank you for such a quick response! Looks like I've managed to settle down CLA issues :D
I'm aware that |
Support workflow job environments
dbb8203
to
d3c4cac
Compare
OK, thanks for the additional detail. That seems reasonable. I will need to review and see how this will impact our pipelines. I'll get back to you shortly. |
Summary
GitHub Actions environments are now generally available for GitHub Actions on GitHub Enterprise Server. Changes address it by adding the
Environment
field into the workflow job struct.Use Cases
Adding the environment to the workflow job when building a pipeline.
Checklist