Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add latest_by_creation_time option to the github-release-dependency #744

Conversation

pbusko
Copy link
Contributor

@pbusko pbusko commented Jul 11, 2022

Summary

This change adds the latest_by_creation_time input option to the github-release-dependency action, which (if specified) will make the action to use the latest github release, sorted by the creation time.

Use Cases

For projects that are using more than 3 digits in their version, after the NormalizeVersion has modified the version from release, additional version digits are moved into the PreRelease field.

For example, the latest JDK 17 version of SapMachine is 17.0.3.0.1, which is normalised to 17.0.3-0.1. Following the Semver spec, 17.0.3 > 17.0.3-0.1

For reference, JEP-322 reserves the 4th and 5th digits for upstream and vendor-specific changes.

Checklist

  • I have viewed, signed, and submitted the Contributor License Agreement.
  • I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
  • I have added an integration test, if necessary.
  • I have reviewed the styleguide for guidance on my code quality.
  • I'm happy with the commit history on this PR (I have rebased/squashed as needed).

@pbusko pbusko requested a review from a team July 11, 2022 14:13
@dmikusa dmikusa added type:enhancement A general enhancement semver:minor A change requiring a minor version bump labels Jul 13, 2022
@pivotal-david-osullivan pivotal-david-osullivan merged commit 6f70ef7 into paketo-buildpacks:main Jul 13, 2022
@pbusko pbusko deleted the filter-gh-releases-by-timestamp branch July 13, 2022 15:29
This was referenced Jul 13, 2022
This was referenced Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver:minor A change requiring a minor version bump type:enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants