-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add latest_by_creation_time option to the github-release-dependency #744
Merged
pivotal-david-osullivan
merged 1 commit into
paketo-buildpacks:main
from
sap-contributions:filter-gh-releases-by-timestamp
Jul 13, 2022
Merged
Add latest_by_creation_time option to the github-release-dependency #744
pivotal-david-osullivan
merged 1 commit into
paketo-buildpacks:main
from
sap-contributions:filter-gh-releases-by-timestamp
Jul 13, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Pavel Busko <[email protected]>
dmikusa
added
type:enhancement
A general enhancement
semver:minor
A change requiring a minor version bump
labels
Jul 13, 2022
dmikusa
approved these changes
Jul 13, 2022
This was referenced Jul 13, 2022
This was referenced Jul 13, 2022
This was referenced Jul 14, 2022
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This change adds the
latest_by_creation_time
input option to thegithub-release-dependency
action, which (if specified) will make the action to use the latest github release, sorted by the creation time.Use Cases
For projects that are using more than 3 digits in their version, after the
NormalizeVersion
has modified the version from release, additional version digits are moved into thePreRelease
field.For example, the latest JDK 17 version of SapMachine is
17.0.3.0.1
, which is normalised to17.0.3-0.1
. Following the Semver spec,17.0.3
>17.0.3-0.1
For reference, JEP-322 reserves the 4th and 5th digits for upstream and vendor-specific changes.
Checklist