[core] feat(Text): allow passing HTML props (#4798)

palantir · Jul 7, 2021 · 9be03db · 9be03db · blueprint-bot · Jul 7, 2021
1 parent 01d2d77
commit 9be03db
Showing 1 changed file with 10 additions and 10 deletions.
diff --git a/packages/core/src/components/text/text.tsx b/packages/core/src/components/text/text.tsx
@@ -52,12 +52,14 @@ export interface ITextState {
 }
 
 @polyfill
-export class Text extends AbstractPureComponent2<TextProps, ITextState> {
+export class Text extends AbstractPureComponent2<
+    TextProps & Omit<React.HTMLAttributes<HTMLElement>, "title">,
+    ITextState
+> {
     public static displayName = `${DISPLAYNAME_PREFIX}.Text`;
 
     public static defaultProps: Partial<TextProps> = {
         ellipsize: false,
-        tagName: "div",
     };
 
     public state: ITextState = {
@@ -76,17 +78,15 @@ export class Text extends AbstractPureComponent2<TextProps, ITextState> {
     }
 
     public render() {
-        const classes = classNames(
-            {
-                [Classes.TEXT_OVERFLOW_ELLIPSIS]: this.props.ellipsize,
-            },
-            this.props.className,
-        );
-        const { children, tagName, title } = this.props;
+        const { children, className, ellipsize, tagName = "div", title, ...htmlProps } = this.props;
+        const classes = classNames(className, {
+            [Classes.TEXT_OVERFLOW_ELLIPSIS]: ellipsize,
+        });
 
         return React.createElement(
-            tagName!,
+            tagName,
             {
+                ...htmlProps,
                 className: classes,
                 ref: (ref: HTMLElement | null) => (this.textRef = ref),
                 title: title ?? (this.state.isContentOverflowing ? this.state.textContent : undefined),