[popover2] Popover2 and ContextMenu2 fixes & enhancements #4601
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ported changes on
v4
branch from #4588 and #4595 ontodevelop
.Fixes #4537
Checklist
Changes proposed in this pull request:
positioningStrategy
prop for Popover2popoverClassName
prop for ContextMenu2ContextMenu2
's styles to use their own classes instead ofContextMenu
's, add the relevant Sass stylesheet.bp3-fixed-positioning-containing-block
which is used to give hints to child / ancestor elements which useposition: fixed
and need to know about their containing block for proper layout calculations. See MDN docs. Use this new utility class inCollapse
andContextMenu2
to fix ContextMenu2 with Tree - wrong open position #4537.ContextMenu2RenderProps
to include the mouse event likeContextMenuTarget
did, to improve compatibility with existing use cases in the wild (like I encountered in the table package in [v4] [table] migrate from ContextMenuTarget to ContextMenu2 #4595)className
,disabled
, andonContextMenu
props for ContextMenu2Reviewers should focus on:
Already reviewed