Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix lint script in CI #4716

Merged
merged 4 commits into from
May 12, 2021
Merged

chore: fix lint script in CI #4716

merged 4 commits into from
May 12, 2021

Conversation

adidahiya
Copy link
Contributor

@adidahiya adidahiya commented May 12, 2021 •
edited
Loading

Fixes #4710

Changes proposed in this pull request:

  • Fix sass-lint script so that it exits correctly with an error code when it fails
  • Make 'compile' job a dependency of the 'lint' job in CI (we need it for lint rules which rely on type information like deprecation/deprecation and for custom rules in our repo)
  • Fix lint errors existing in repo

@blueprint-bot
Copy link

chore: fix lint script in CI

Previews: documentation | landing | table

@blueprint-bot
Copy link

lint depends on compile

Previews: documentation | landing | table

@blueprint-bot
Copy link

fix lint

Previews: documentation | landing | table

@blueprint-bot
Copy link

fix more lint

Previews: documentation | landing | table

@adidahiya adidahiya marked this pull request as ready for review May 12, 2021 20:11
@adidahiya adidahiya merged commit 6ba74fe into develop May 12, 2021
@adidahiya adidahiya deleted the ad/fix-ci-lint branch May 12, 2021 20:12
This was referenced Oct 15, 2021
Open
Open
Open
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Lint Fails in Local Environment
2 participants
@adidahiya @blueprint-bot