[core] fix(Button): revert 12px font size change in small button #4905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[core] fix(Button): revert 12px font size change in small buttonsPreviews: documentation | landing | table |
adidahiya
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts the functional part of #4885
Changes proposed in this pull request:
After testing out this 12px font change in practice, we found that it had an outsized impact and cost which outweighed its benefits of achieving button/input consistency. We found many places where small buttons were used for their small padding styling but were not suitable for displaying 12px text. In the interest of Blueprint 4.0 rollout speed, we've decided to revert this change and address it at a different time.