You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adjust Overlay's focus management behavior to avoid programmatically focussing elements inside the overlay contents in most cases, opting for keeping focus on the start/end focus trap elements instead
Reviewers should focus on:
We should still get the accessibility enhancements added by #4894, but without the overly invasive focus management which caused issues like #4956.
There are issues with reverse TAB key navigation with this change. Here's an example where I press TAB x4 times and then SHIFT+TAB x4 times after clicking the button to open this dialog:
When pressing SHIFT+TAB, we expect the focus to cycle back from the end of the dialog and up through the focusable elements. Instead, it appears that nothing happens and the focus stays on the end focus trap element.
Things are better now, but there's still a minor issue where the second to last focusable element in the dialog seems to get focussed after pressing Shift+Tab at the end of the dialog. It's turning out to be a tricky one to fix... will probably just punt it for later, since this change seems like a strict improvement over the current state of things.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4956, fixes #4920, and related issues
Checklist
Changes proposed in this pull request:
Adjust Overlay's focus management behavior to avoid programmatically focussing elements inside the overlay contents in most cases, opting for keeping focus on the start/end focus trap elements instead
Reviewers should focus on:
We should still get the accessibility enhancements added by #4894, but without the overly invasive focus management which caused issues like #4956.
Screenshot