Panic when not able to delete compaction waste #573
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In both cases, we can prevent resurrection by refusing to compact after this case has been encountered, but this will cause the node to fall behind on compactions which will take longer to resolve than a bounce. We haven't observed either of these cases directly, which indicates that this failure mode is infrequent enough that a forced restart is an acceptable alternative to stopping compactions that doesn't risk extended perf degradation.