Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update godel to 2.18.0 and Go to 1.13.3 #38

Merged
merged 1 commit into from
Oct 31, 2019
Merged

Update godel to 2.18.0 and Go to 1.13.3 #38

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,14 +4,14 @@ owner-repo: &owner-repo
excutor: &executor
executor:
name: go/darwin-linux-no-cgo
version: 1.13.3-t27
<<: *owner-repo
module: false

version: 2.1

orbs:
go: palantir/[email protected].11
godel: palantir/[email protected].9
go: palantir/[email protected].13
godel: palantir/[email protected].11

all-tags-filter: &all-tags-filter
filters:
Expand All @@ -31,13 +31,16 @@ workflows:
name: test
<<: *executor
<<: *all-tags-filter
mod-cache: false
- godel/dist:
name: dist
<<: *executor
<<: *all-tags-filter
mod-cache: false
- godel/bintray-publish:
name: publish
<<: *executor
mod-cache: false
bintray-subject: palantir
bintray-repo: releases
bintray-product: godel-okgo-asset-outparamcheck
Expand Down
12 changes: 5 additions & 7 deletions generated_src/internal/github.com/palantir/outparamcheck/amalgomated_flag/flag.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -341,17 +341,15 @@ type Flag struct {

// sortFlags returns the flags as a slice in lexicographical sorted order.
func sortFlags(flags map[string]*Flag) []*Flag {
list := make(sort.StringSlice, len(flags))
result := make([]*Flag, len(flags))
i := 0
for _, f := range flags {
list[i] = f.Name
result[i] = f
i++
}
list.Sort()
result := make([]*Flag, len(list))
for i, name := range list {
result[i] = flags[name]
}
sort.Slice(result, func(i, j int) bool {
return result[i].Name < result[j].Name
})
return result
}

Expand Down
4 changes: 2 additions & 2 deletions godel/config/godel.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
distributionURL=https://palantir.bintray.com/releases/com/palantir/godel/godel/2.13.0/godel-2.13.0.tgz
distributionSHA256=9b1d12293ac81bdeba7f637125468beba594979d8a45b166164ed0c9f31f799c
distributionURL=https://palantir.bintray.com/releases/com/palantir/godel/godel/2.18.0/godel-2.18.0.tgz
distributionSHA256=b3bdbddb7e8347adbf9d3328b12efbf5d178e7dfc7353a2cacbbd12ef404b8f6
6 changes: 3 additions & 3 deletions godelw
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,9 @@
set -euo pipefail

# Version and checksums for godel. Values are populated by the godel "dist" task.
VERSION=2.13.0
DARWIN_CHECKSUM=a2f5355729f43b6b174a2a26993b2067cef61af240f650def6359c3bad7ba91d
LINUX_CHECKSUM=d7c147949f43f1930d013bac33af19e1d47aad8bed5fdb3cad0cceddd36d8ff4
VERSION=2.18.0
DARWIN_CHECKSUM=fd748300ee17d3cb7ef348b0c76d800320974446fe447ae82a5273d64dbd9b54
LINUX_CHECKSUM=de1159510634db0467e60bce67d38735498dd5f9be74bfb90d340621683cfb75

# Downloads file at URL to destination path using wget or curl. Prints an error and exits if wget or curl is not present.
function download {
Expand Down