Add pylint support. #385
Add pylint support. #385
Conversation
|
Thanks for your interest in palantir/python-language-server, @DanAlbert! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request. |
DanAlbert
force-pushed
the
pylint-support
branch
3 times, most recently
from
f1cf714
to
e7b1049
Compare
|
Why are the circleci and appveyor/branch checks stuck? There aren't any links for me to see what went wrong. Have they just not started? |
DanAlbert
force-pushed
the
pylint-support
branch
from
9e5f1e6
to
ca6dca3
Compare
|
Just updated with a couple more bug fixes and matching test cases. |
|
Any comments around this merge? Would love Pylint in pyls! |
|
It'd be great to have pylint supported by pyls. The truth is pylint is the only thing we miss |
|
Any news about this PR? |
|
Any news? |
This will change with pylint-dev/pylint#2746 ;) |
|
Thanks for the feedback, and sorry I haven't had a chance to respond yet. I'll try to address the requested changes soon so we can get this merged. |
DanAlbert
force-pushed
the
pylint-support
branch
from
24b35a8
to
5d5d300
Compare
This also adds an `is_saved` argument to the pyls_lint hookspec, since pylint doesn't expose an API for operating on in-memory contents, only files.
DanAlbert
force-pushed
the
pylint-support
branch
from
5d5d300
to
d477839
Compare
|
Alright, addressed all the review comments and rebased on top of ToT, all tests still passing. |
|
Great, now how does one disable this? "pylint": {
"enabled": false
},The above does not work as it would for any other plugin. |
|
Now how does one pass flags to pylint? |
This also adds an
is_savedargument to the pyls_lint hookspec, sincepylint doesn't expose an API for operating on in-memory contents, only
files.
Fixes #129