Specify relevant document path when retrieving some plugin settings #845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccordoba12
reviewed
Oct 5, 2020
There was a problem hiding this comment.
Thanks for your contribution @mnauw! This looks good to me, but please apply your changes also to the Mccabe and Pydocstyle linters.
... particularly those that are extracted from configuration files relative to document location See also PR #418
|
As suggested, the changes have also been applied to the Mccabe and Pydocstyle linters (and rebased on current |
ccordoba12
approved these changes
Oct 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... particularly those that are extracted from configuration files
relative to document location
See also PR #418