Merge existing registry with default one or configure default metric registry #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will submit upstream together with codahale bump |
ash211
reviewed
Jun 22, 2017
| @@ -79,6 +79,13 @@ private[spark] class MetricsSystem private ( | |||
| private val sources = new mutable.ArrayBuffer[Source] | |||
| private val registry = new MetricRegistry() | |||
|
|
|||
| try { | |||
| registry.registerAll(SharedMetricRegistries.getDefault) | |||
There was a problem hiding this comment.
has the default shared metric registry had all the metrics already registered with it at this point in code execution? it looks like this is a one-time registration so metrics registered with the shared registry afterwards would not be added to Spark's registry
There was a problem hiding this comment.
@ash211 added listeners to propagate metrics from sources and default registry. This should behave correctly or am I misunderstanding?
robert3005
force-pushed
the
rk/default-registry
branch
from
d4fcc66
to
82ad56a
Compare
|
Created apache#18406 for upstream |
robert3005
force-pushed
the
rk/default-registry
branch
2 times, most recently
from
d434867
to
d001540
Compare
robert3005
force-pushed
the
rk/default-registry
branch
from
361dd21
to
a7a42d1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lets users plug into spark metrics via default metric registry