[SPARK-25200][YARN] Allow specifying HADOOP_CONF_DIR as spark property #407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
August 30, 2018 14:05
This reverts commit f8e828c.
robert3005
approved these changes
Sep 12, 2018
| val confDirsEnvKeys = Seq("HADOOP_CONF_DIR", "YARN_CONF_DIR") | ||
| val confDirProp = sparkConf.getOption("spark.yarn.conf.dir") | ||
|
|
||
| val confDirPaths = (confDirsEnvKeys.map(sys.env.get) :+ confDirProp).flatMap(_.toList) |
|
Going to repush to this repo so that tests run |
|
Thanks for the swift review @robert3005 ! I made the changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SPARK-25200 - apache#22289
Replicates the behaviour of setting
HADOOP_CONF_DIR, but as a spark configspark.yarn.conf.dir