Fix regression in CheckstyleFormatter backwards compatibility (#4561)

palantir · Mar 1, 2019 · 25c50e7 · 25c50e7
1 parent 1c400fb
commit 25c50e7
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/src/formatters/checkstyleFormatter.ts b/src/formatters/checkstyleFormatter.ts
@@ -38,8 +38,8 @@ export class Formatter extends AbstractFormatter {
     };
     /* tslint:enable:object-literal-sort-keys */
 
-    public format(failures: RuleFailure[], _fixes: RuleFailure[], fileNames: string[]): string {
-        const groupedFailures: { [k: string]: RuleFailure[] } = {};
+    public format(failures: RuleFailure[], _fixes?: RuleFailure[], fileNames?: string[]): string {
+        const groupedFailures: { [fileName: string]: RuleFailure[] } = {};
         for (const failure of failures) {
             const fileName = failure.getFileName();
             if (groupedFailures[fileName] !== undefined) {
@@ -49,6 +49,10 @@ export class Formatter extends AbstractFormatter {
             }
         }
 
+        if (fileNames === undefined) {
+            fileNames = Object.keys(groupedFailures);
+        }
+
         const formattedFiles = fileNames.map(fileName => {
             const formattedFailures =
                 groupedFailures[fileName] !== undefined

diff --git a/src/language/formatter/abstractFormatter.ts b/src/language/formatter/abstractFormatter.ts
@@ -23,8 +23,8 @@ export abstract class AbstractFormatter implements IFormatter {
     public static metadata: IFormatterMetadata;
     public abstract format(
         failures: RuleFailure[],
-        fixes: RuleFailure[],
-        fileNames: string[],
+        fixes?: RuleFailure[],
+        fileNames?: string[],
     ): string;
 
     protected sortFailures(failures: RuleFailure[]): RuleFailure[] {