array-type: undefined and never now considered simple types (#1843

)
palantir · Mar 6, 2017 · 3923abf · 3923abf
1 parent f11c308
commit 3923abf
Show file tree

Hide file tree

Showing 5 changed files with 8 additions and 6 deletions.
diff --git a/src/rules/arrayTypeRule.ts b/src/rules/arrayTypeRule.ts
@@ -110,10 +110,12 @@ class ArrayTypeWalker extends Lint.RuleWalker {
             case ts.SyntaxKind.ArrayType:
             case ts.SyntaxKind.BooleanKeyword:
             case ts.SyntaxKind.NullKeyword:
+            case ts.SyntaxKind.UndefinedKeyword:
             case ts.SyntaxKind.NumberKeyword:
             case ts.SyntaxKind.StringKeyword:
             case ts.SyntaxKind.SymbolKeyword:
             case ts.SyntaxKind.VoidKeyword:
+            case ts.SyntaxKind.NeverKeyword:
                 return true;
             case ts.SyntaxKind.TypeReference:
                 // TypeReferences must be non-generic or be another Array with a simple type

diff --git a/test/rules/array-type/array-simple/test.ts.fix b/test/rules/array-type/array-simple/test.ts.fix
@@ -1,4 +1,4 @@
-let x: number[] = [1] as number[];
+let x: undefined[] = [undefined] as undefined[];
 let y: string[] = <string[]>["2"];
 let z: any[] = [3, "4"];
 

diff --git a/test/rules/array-type/array-simple/test.ts.lint b/test/rules/array-type/array-simple/test.ts.lint
@@ -1,5 +1,5 @@
-let x: Array<number> = [1] as number[];
-       ~~~~~~~~~~~~~                    [Array type using 'Array<T>' is forbidden for simple types. Use 'T[]' instead.]
+let x: Array<undefined> = [undefined] as undefined[];
+       ~~~~~~~~~~~~~~~~                               [Array type using 'Array<T>' is forbidden for simple types. Use 'T[]' instead.]
 let y: string[] = <Array<string>>["2"];
                    ~~~~~~~~~~~~~        [Array type using 'Array<T>' is forbidden for simple types. Use 'T[]' instead.]
 let z: Array = [3, "4"];

diff --git a/test/rules/array-type/array/test.ts.fix b/test/rules/array-type/array/test.ts.fix
@@ -1,4 +1,4 @@
-let x: number[] = [1] as number[];
+let x: undefined[] = [undefined] as undefined[];
 let y: string[] = <string[]>["2"];
 let z: any[] = [3, "4"];
 

diff --git a/test/rules/array-type/array/test.ts.lint b/test/rules/array-type/array/test.ts.lint
@@ -1,5 +1,5 @@
-let x: Array<number> = [1] as number[];
-       ~~~~~~~~~~~~~                    [Array type using 'Array<T>' is forbidden. Use 'T[]' instead.]
+let x: Array<undefined> = [undefined] as undefined[];
+       ~~~~~~~~~~~~~~~~                               [Array type using 'Array<T>' is forbidden. Use 'T[]' instead.]
 let y: string[] = <Array<string>>["2"];
                    ~~~~~~~~~~~~~        [Array type using 'Array<T>' is forbidden. Use 'T[]' instead.]
 let z: Array = [3, "4"];