Skip to content
This repository has been archived by the owner on Mar 25, 2021. It is now read-only.

false negative: no-internal-module #1069

Closed
unional opened this issue Mar 28, 2016 · 1 comment
Closed

false negative: no-internal-module #1069

unional opened this issue Mar 28, 2016 · 1 comment
Labels
Difficulty: Easy P1 Resolution: Fixed Type: Bug
Milestone
TSLint 3.8

Comments

@unional
Copy link
Contributor

unional commented Mar 28, 2016

https://github.com/typed-typings/npm-chai/blob/master/lib/Chai.d.ts#L28-L33

/* tslint:disable:no-internal-module */
declare global {
  interface Object {
    should: A.Assertion;
  }
}

Global augmentation is detected as internal module.
@jkillian
Copy link
Contributor

jkillian commented Apr 8, 2016

For context, this is a fairly new feature of TypeScript: microsoft/TypeScript#6213

jkillian pushed a commit that referenced this issue Apr 8, 2016
Fix false positive from no-internal-module on global augmentation
cc431f8 
Fixes #1069
jkillian pushed a commit that referenced this issue Apr 8, 2016
Fix false positive from no-internal-module on global augmentation
1413d5a 
Fixes #1069
@jkillian jkillian mentioned this issue Apr 8, 2016
Merged
adidahiya pushed a commit that referenced this issue Apr 8, 2016
@jkillian @adidahiya
Fix false positive from no-internal-module on global augmentation (#1098
b735e2d 
)

Fixes #1069
@adidahiya adidahiya added this to the TSLint 3.8 milestone Apr 8, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Difficulty: Easy P1 Resolution: Fixed Type: Bug
Projects
None yet
Milestone
TSLint 3.8
Development

No branches or pull requests
3 participants
@adidahiya @jkillian @unional