Skip to content
This repository has been archived by the owner on Mar 25, 2021. It is now read-only.

Trailing comma rule now encompasses function decls, exprs and types #1486

Merged
merged 3 commits into from
Sep 12, 2016
Merged

Trailing comma rule now encompasses function decls, exprs and types #1486

merged 3 commits into from
Sep 12, 2016

Commits on Sep 12, 2016

  1. Trailing comma rule now encompasses function decls, exprs and types

    Mark Wong Siang Kai committed Sep 12, 2016
    Configuration menu
    Copy the full SHA
    13ddeb6 View commit details
    Browse the repository at this point in the history

  2. Trailing comma support for ctor, iface, class, type params, methods, … 

    …set accessor, function calls

-- Untested:
   1. ctor calls (should be handled by callSignature)
   2. set accessor calls (should be handled by callSignature)
   3. tuple/function/ctor/parameterized return types (should be
      handled syntax walker recursion and should hit one of
      vist...[TupleType, FunctionType, ConstructorType, TypeReference, TypeLiteral])
   4. Enums (I think this will fail)

-- Known not working:
   1. comma separated object literal types (object literals can
      be semicolon delineated, so need a good way to only cry
      about trailing commas if they aren't semicolon delineated)

-- Known won't fix:
   1. iface/class extension list (tsc does not support trailing
      commas)
    Mark Wong Siang Kai committed Sep 12, 2016
    Configuration menu
    Copy the full SHA
    1c7b96f View commit details
    Browse the repository at this point in the history

  3. Handle objects and enums

    Mark Wong Siang Kai committed Sep 12, 2016
    Configuration menu
    Copy the full SHA
    dd0e5fc View commit details
    Browse the repository at this point in the history