Skip to content
This repository has been archived by the owner on Mar 25, 2021. It is now read-only.

Add auto-fixes for trailing-comma #1546

Merged
merged 1 commit into from
Sep 14, 2016
Merged

Conversation

alexeagle
Copy link
Contributor

No description provided.

@palantirtech
Copy link
Member

Thanks for your interest in palantir/tslint, @alexeagle! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request.

@alexeagle
Copy link
Contributor Author

CLA: the commit is authored with my @google.com address, which is corporate signed.

@jkillian
Copy link
Contributor

Thanks @alexeagle, this'll be a useful auto-fix. Are you aware of @markwongsk's PR, #1486, to make sure that the trailing-comma rule is applied evenly everywhere? Might be worth basing this branch off of his - hope it isn't too much additional work

@alexeagle
Copy link
Contributor Author

That rebase looks easy, no worries. I just copy-paste the .lint file and do
whatever the ~~~ says, then delete it :)

On Sat, Sep 10, 2016 at 7:40 PM Jason Killian [email protected]
wrote:

Thanks @alexeagle https://github.com/alexeagle, this'll be a useful
auto-fix. Are you aware of @markwongsk https://github.com/markwongsk's
PR, #1486 #1486, to make sure
that the trailing-comma rule is applied evenly everywhere? Might be worth
basing this branch off of his - hope it isn't too much additional work


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#1546 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAC5I5g5Cs9KSrIom6uqGu3qS7YdOhUqks5qo2ocgaJpZM4J54dp
.

@markwongsk
Copy link
Contributor

Hey @alexeagle I updated my PR to be based off master and to point at master. You should be able to rebase now :)

@alexeagle
Copy link
Contributor Author

thanks, rebased now, PTAL @jkillian

@jkillian jkillian merged commit e048ca4 into palantir:master Sep 14, 2016
@jkillian
Copy link
Contributor

Thanks!

@adidahiya adidahiya added this to the TSLint v4.0 milestone Sep 19, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants