Skip to content
This repository has been archived by the owner on Mar 25, 2021. It is now read-only.

Add fix for no-unused-variable, only for imports #1568

Merged
merged 1 commit into from
Oct 7, 2016
Merged

Add fix for no-unused-variable, only for imports #1568

merged 1 commit into from
Oct 7, 2016

Conversation

alexeagle
Copy link
Contributor

@palantirtech
Copy link
Member

Thanks for your interest in palantir/tslint, @alexeagle! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request.

@alexeagle
Copy link
Contributor Author

cc @ScottSWu too - we talked about this one a couple times

@alexeagle alexeagle force-pushed the fixUnusedImport2 branch 2 times, most recently from 37d5b75 to 78f2bba Compare September 23, 2016 04:20
@alexeagle alexeagle mentioned this pull request Sep 23, 2016
Closed
@alexeagle alexeagle force-pushed the fixUnusedImport2 branch 2 times, most recently from 480a539 to 91e591a Compare September 23, 2016 17:34
@alexeagle alexeagle mentioned this pull request Sep 23, 2016
Closed
@alexeagle
Copy link
Contributor Author

cc @paulvanbrenk I think this handles more cases than https://github.com/Microsoft/TypeScript/blob/pvb/discoverCodeActions/src/services/codefixes/unusedIdentifierFixes.ts
is that up-to-date? Where do we want to land this feature? I don't think tslint and typescript need two independent implementations...

alexeagle added a commit to alexeagle/angular that referenced this pull request Sep 27, 2016
@alexeagle
chore(lint): remove unused imports
291a0a6 
This was done automatically by tslint, which can now fix issues it finds.
The fixer is still pending in PR palantir/tslint#1568
Also I have a local bugfix for palantir/tslint#1569
which causes too many imports to be deleted.
@alexeagle alexeagle mentioned this pull request Sep 27, 2016
Merged
3 tasks
alexeagle added a commit to alexeagle/angular that referenced this pull request Sep 27, 2016
@alexeagle
chore(lint): remove unused imports
e609eab 
This was done automatically by tslint, which can now fix issues it finds.
The fixer is still pending in PR palantir/tslint#1568
Also I have a local bugfix for palantir/tslint#1569
which causes too many imports to be deleted.
alexeagle added a commit to alexeagle/angular that referenced this pull request Sep 27, 2016
@alexeagle
chore(lint): remove unused imports
b2a1415 
This was done automatically by tslint, which can now fix issues it finds.
The fixer is still pending in PR palantir/tslint#1568
Also I have a local bugfix for palantir/tslint#1569
which causes too many imports to be deleted.
rkirov pushed a commit to angular/angular that referenced this pull request Sep 28, 2016
@alexeagle @rkirov
chore(lint): remove unused imports (#11923)
41c8c30 
This was done automatically by tslint, which can now fix issues it finds.
The fixer is still pending in PR palantir/tslint#1568
Also I have a local bugfix for palantir/tslint#1569
which causes too many imports to be deleted.
chuckjaz pushed a commit to chuckjaz/angular that referenced this pull request Oct 5, 2016
@alexeagle @chuckjaz
chore(lint): remove unused imports (angular#11923)
9d344bb 
This was done automatically by tslint, which can now fix issues it finds.
The fixer is still pending in PR palantir/tslint#1568
Also I have a local bugfix for palantir/tslint#1569
which causes too many imports to be deleted.
chuckjaz pushed a commit to angular/angular that referenced this pull request Oct 5, 2016
@alexeagle @chuckjaz
chore(lint): remove unused imports (#11923)
830e635 
This was done automatically by tslint, which can now fix issues it finds.
The fixer is still pending in PR palantir/tslint#1568
Also I have a local bugfix for palantir/tslint#1569
which causes too many imports to be deleted.
@alexeagle
Copy link
Contributor Author

Ping!

@adidahiya adidahiya self-assigned this Oct 7, 2016
@alexeagle
Copy link
Contributor Author

Note, my fix for #1569 is based on this one

adidahiya
adidahiya approved these changes Oct 7, 2016
View reviewed changes
Copy link
Contributor

@adidahiya adidahiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the test coverage @alexeagle.

@adidahiya adidahiya merged commit b5ef1b4 into palantir:master Oct 7, 2016
@nchen63 nchen63 added this to the TSLint v4.0 milestone Nov 8, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@adidahiya adidahiya adidahiya approved these changes

Assignees

@adidahiya adidahiya

Labels
None yet
Projects
None yet
Milestone
TSLint v4.0
Development

Successfully merging this pull request may close these issues.
4 participants
@alexeagle @palantirtech @adidahiya @nchen63