This repository has been archived by the owner on Mar 25, 2021. It is now read-only.
Add match-default-export-name rule
#2117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
very cool! this programming error was one of my main motivations for the no-default-export rule. |
…h_default_export_name
nchen63
suggested changes
Jan 29, 2017
| @@ -0,0 +1,3 @@ | |||
| import b from "./named"; | |||
| ~ [Default export 'a' is imported as 'b'.] | |||
| import anyName from "./anonymous"; | |||
There was a problem hiding this comment.
add test for import a as b. Users look at tests to understand how the rule works
There was a problem hiding this comment.
That's not legal syntax anyway.
| /* tslint:enable:object-literal-sort-keys */ | ||
|
|
||
| public static FAILURE_STRING(importName: string, exportName: string): string { | ||
| return `Default export '${exportName}' is imported as '${importName}'.`; |
There was a problem hiding this comment.
Prefer something that indicates how to resolve the issue like Expected import '${importName}' to match the default export '${exportName}'
|
|
||
| import * as Lint from "../index"; | ||
|
|
||
| export class Rule extends Lint.Rules.AbstractRule { |
There was a problem hiding this comment.
use TypedRule and applyWithProgram
nchen63
approved these changes
Jan 29, 2017
|
@andy-hanson thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
What changes did you make?
Added the
match-default-export-namerule, which requires that default imports have the same name as the default exports they reference.This doesn't check named exports, since they require explicit
import { foo as bar }and are unlikely to be name-changed by mistake.This also doesn't check
import =andexport =, sinceexport =comes from declaration files which probably don't use the name you want, and if it's an@typesmodule you can't simply change it.