This repository has been archived by the owner on Mar 25, 2021. It is now read-only.
Add return-undefined rule
#2251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nchen63
suggested changes
Mar 6, 2017
src/rules/returnUndefinedRule.ts
Outdated
| return; | ||
| } | ||
|
|
||
| const returnKindFromExpression = !node.expression |
src/rules/returnUndefinedRule.ts
Outdated
| return; | ||
| } | ||
|
|
||
| const functionReturningFrom = Lint.ancestorWhere(node, isFunctionLike)! as FunctionLike; |
There was a problem hiding this comment.
Should handle undefined return value properly. This may crash TSLint later when linting invalid code.
nchen63
approved these changes
Mar 20, 2017
|
@andy-hanson broke master when merged. Looks like it needs to converted to use |
Merged
AJamesPhillips
pushed a commit
to AJamesPhillips/tslint
that referenced
this pull request
Mar 23, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
Overview of change:
Adds the
return-undefinedrule, which specifies when to preferreturn;vsreturn undefined;.CHANGELOG.md entry:
[new-rule]
return-undefined