This repository has been archived by the owner on Mar 25, 2021. It is now read-only.
Mentioned file name in test script parse failures #4390
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Interesting! I was looking into this issue myself. If you don't mind, I would like to take a stab at adding tests around the change. |
|
@aprilrd that'd be great! Feel free to send a new PR with my changes or your own if you'd prefer! |
|
Cool! I will try to work something out in the next couple of days |
3 tasks
|
I made a PR with your change, and my tests at #4397 :) |
|
Sweet, thanks @aprilrd! I'll take a look now. |
JoshuaKGoldberg
added
Resolution: Duplicate
and removed
PR: waiting for reviewer
labels
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
Overview of change:
Adds the file name when test file parsing fails.
Nobody's commented on the issue but I had the code working locally; figured I'd send the PR anyway.
CHANGELOG.md entry:
[enhancement] Mentioned file name in test script parse failures