-
Notifications
You must be signed in to change notification settings - Fork 889
add jsx-ignore option to no-magic-numbers rule #4460
add jsx-ignore option to no-magic-numbers rule #4460
Conversation
Thanks for your interest in palantir/tslint, @lizzzp1! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Exciting!, but needs some structural changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like it's working! Some structural changes around option parsing, but the node/walking logic looks great.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just the one nitpick. Leaving this unedited if you want the satisfaction of applying the code change yourself 😄 otherwise I'll just make it & merge this in next week. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙌 Thanks @lizzzp1! This looks great.
PR checklist
Overview of change:
Attempts to add an option to ignore jsx and leaves default as is.
Is there anything you'd like reviewers to focus on?
First PR in here, I may have missed some things. :)
Feedback appreciated.
CHANGELOG.md entry:
[new-rule-option] added
jsx-ignore
option tono-magic-numbers
rule