Skip to content
This repository has been archived by the owner on Mar 25, 2021. It is now read-only.

Fix #4556 - False positive: No void expression #4606

Merged
merged 1 commit into from
Mar 26, 2019
Merged

Fix #4556 - False positive: No void expression #4606

merged 1 commit into from
Mar 26, 2019

Conversation

rrogowski
Copy link
Contributor

PR checklist

Overview of change:

Allow void expressions in conditional expressions.

Is there anything you'd like reviewers to focus on?

Any extra test cases you would like me to cover?

CHANGELOG.md entry:

[bugfix] no-void-expression now allows conditional expressions

Copy link
Contributor

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice & simple, thanks! 🙌

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

False positive: No void expression
2 participants